Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bot token from component-owners.yml #4869

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Remove bot token from component-owners.yml #4869

merged 3 commits into from
Jul 23, 2024

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Jul 23, 2024

No description provided.

@svrnm svrnm requested a review from a team July 23, 2024 18:05
@svrnm svrnm merged commit bf49f3a into main Jul 23, 2024
19 checks passed
@svrnm svrnm deleted the svrnm-patch-3 branch July 23, 2024 18:19
@trentm
Copy link
Contributor

trentm commented Jul 24, 2024

COuld this be the cause of recent failures of the "Component Owners" check on recent PRs in this repo? E.g.:

The former is failing (https://github.com/open-telemetry/opentelemetry.io/actions/runs/10065550928/job/27824924682?pr=4824) with:

Error: Validation Failed: "Could not resolve to a node with the global id of 'MDQ6VGVhbTMyNDc5MDQ='." - https://docs.github.com/rest/pulls/review-requests#request-reviewers-for-a-pull-request

Unfortunately that GitHub REST API doc section doesn't specify the permissions this API requires. I think some APIs do document this. A guess is that it requires some permissions beyond just:

    permissions:
      contents: read
      pull-requests: write

@trentm
Copy link
Contributor

trentm commented Jul 24, 2024

Unfortunately that GitHub REST API doc section doesn't specify the permissions this API requires.

I'm wrong. Those docs say:

The fine-grained token must have the following permission set:

"Pull requests" repository permissions (write)

... which you've added, so I'm not sure what the problem is.

@svrnm
Copy link
Member Author

svrnm commented Jul 24, 2024

Yes. This is related. We need a PTA with more permissions to make this work. I raised a community issue for this being fixed, but I will likely need to revert this until this is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants